Fix the inclusion of strcasestr() used by the vCard parser.

[pkg/abook.git] / options.c

diff --git a/options.c b/options.c
index a370a30ddd1c7cdb749e2ffd541c562de7db8f98..84f08ca64152564978f04c6821751835602f10d6 100644 (file)
--- a/options.c
+++ b/options.c
@@ -50,11 +50,7 @@ static struct option abook_vars[] = {
        { "autosave", OT_BOOL, BOOL_AUTOSAVE, TRUE },
 
        { "show_all_emails", OT_BOOL, BOOL_SHOW_ALL_EMAILS, TRUE },
-       { "emailpos", OT_INT, INT_EMAILPOS, 25 },
-       { "extra_column", OT_STR, STR_EXTRA_COLUMN, UL "phone" },
-       { "extra_alternative", OT_STR, STR_EXTRA_ALTERNATIVE, UL "-1" },
-       { "extrapos", OT_INT, INT_EXTRAPOS, 65 },
-
+       { "index_format", OT_STR, STR_INDEX_FORMAT, UL " {name:22} {email:40} {phone:12|workphone|mobile}" },
        { "mutt_command", OT_STR, STR_MUTT_COMMAND, UL "mutt" },
        { "mutt_return_all_emails", OT_BOOL, BOOL_MUTT_RETURN_ALL_EMAILS,
                TRUE },
@@ -278,16 +274,17 @@ get_token(buffer *b, int options)
        return NULL;
 }
 
-static char *
+static const char *
 opt_set_set_option(char *p, struct option *opt)
 {
        int len;
 
-       strtrim(p);
+       assert(p);
 
+       strtrim(p);
        len = strlen(p);
 
-       if(p[len - 1] == '\"' && *p == '\"') {
+       if(*p == '\"' && p[len - 1] == '\"') {
                if(len < 3)
                        return _("invalid value");
                p[len - 1] = 0;
@@ -317,11 +314,14 @@ opt_set_set_option(char *p, struct option *opt)
        return NULL;
 }
 
-static char *
+static const char *
 opt_set_option(char *var, char *p)
 {
        int i;
 
+       assert(var);
+       assert(p);
+
        for(i = 0; abook_vars[i].option; i++)
                if(!strcmp(abook_vars[i].option, var))
                        return opt_set_set_option(p, &abook_vars[i]);
@@ -360,7 +360,7 @@ check_options()
 /*
  * syntax: set <option> = <value>
  */
-static char *
+static const char *
 opt_parse_set(buffer *b)
 {
        char *var, *err;
@@ -374,7 +374,7 @@ opt_parse_set(buffer *b)
        return opt_set_option(var, b->ptr);
 }
 
-static char *
+static const char *
 opt_parse_customfield(buffer *b)
 {
        return _("customfield: obsolete command - please use the "
@@ -386,7 +386,7 @@ opt_parse_customfield(buffer *b)
 /*
  * syntax: view <tab name> = <field1> [ , <field2>, ... ]
  */
-static char *
+static const char *
 opt_parse_view(buffer *b)
 {
        char *err, *view;
@@ -416,7 +416,7 @@ opt_parse_view(buffer *b)
 /*
  * syntax: field <identifier> = <human readable name> [ , <type> ]
  */
-static char *
+static const char *
 opt_parse_field(buffer *b)
 {
        char *err, *field, *name;
@@ -445,7 +445,7 @@ opt_parse_field(buffer *b)
 
 static struct {
        char *token;
-       char * (*func) (buffer *line);
+       const char * (*func) (buffer *line);
 } opt_parsers[] = {
        { "set", opt_parse_set },
        { "customfield", opt_parse_customfield }, /* obsolete */
@@ -458,7 +458,7 @@ static bool
 opt_parse_line(char *line, int n, char *fn)
 {
        int i;
-       char *err = NULL;
+       const char *err = NULL;
        char *token;
        buffer b;