use Data::Dumper;
use Exporter;
-use Locale::gettext;
use Deb::Versions;
use Packages::CGI;
+use Packages::I18N::Locale;
our @ISA = qw( Exporter );
our @EXPORT_OK = qw( split_name_mail parse_deps );
$name = $string;
$email = $string;
} else {
- $name = gettext( 'package has bad maintainer field' );
+ $name = N_( 'package has bad maintainer field' );
$email = '';
}
$name =~ s/\s+$//o;
return ($name, $email);
}
+sub override_maint {
+ my ($self, $data) = @_;
+
+ return if $data->{'original-maintainer'};
+ return unless $data->{maintainer};
+
+ my ($name, $mail) = split_name_mail( $data->{maintainer} );
+
+ # taken from etc/pkgbinarymangler/maintainermangler.overrides
+ return if $mail =~ /\@(ubuntu\.com|canonical\.com|lists\.ubuntu\.com|lists\.canonical\.com|ubuntu\.com\.au|kubuntu\.org)^/o;
+ return if $mail =~ /^(lamont\@debian\.org|q-funk\@iki\.fi|cjwatson\@debian\.org|patrick\.matthaei\@web\.de)^/o;
+
+ if ($mail eq 'adconrad@0c3.net') {
+ $data->{maintainer} = 'Adam Conrad <adconrad@ubuntu.com>';
+ return 1;
+ }
+ if ($mail eq 'mpitt@debian.org') {
+ $data->{maintainer} = 'Martin Pitt <martin.pitt@ubuntu.com>';
+ return 1;
+ }
+
+ $data->{'original-maintainer'} = $data->{maintainer};
+ foreach ($data->{section}) {
+ /^(main|restricted)$/ && do {
+ $data->{maintainer} = 'Ubuntu Core Developers <ubuntu-devel-discuss@lists.ubuntu.com>';
+ last;
+ };
+ /^(uni|multi)verse$/ && do {
+ $data->{maintainer} = 'Ubuntu MOTU Developers <ubuntu-motu@lists.ubuntu.com>';
+ last;
+ };
+
+ die 'Huh?';
+ }
+
+ return 1;
+}
+
+sub handle_maintainer_fields {
+ my ($self, $data) = @_;
+ my (@uploaders, @orig_uploaders);
+
+ if ($data->{'original-maintainer'}) {
+ push @orig_uploaders, [ split_name_mail( $data->{'original-maintainer'} ) ];
+
+ $data->{uploaders} ||= '';
+ my @up_tmp = split( /\s*,\s*/,
+ $data->{uploaders} );
+ foreach my $up (@up_tmp) {
+ push @orig_uploaders, [ split_name_mail( $up ) ];
+ }
+ if ($data->{maintainer} ||= '') {
+ push @uploaders, [ split_name_mail( $data->{maintainer} ) ];
+ }
+ } else {
+ if ($data->{maintainer} ||= '') {
+ if ($self->override_maint($data)) {
+ return $self->handle_maintainer_fields($data);
+ }
+
+ push @uploaders, [ split_name_mail( $data->{maintainer} ) ];
+ }
+ if ($data->{uploaders}) {
+ my @up_tmp = split( /\s*,\s*/,
+ $data->{uploaders} );
+ foreach my $up (@up_tmp) {
+ if ($up ne $data->{maintainer}) { # weed out duplicates
+ push @uploaders, [ split_name_mail( $up ) ];
+ }
+ }
+ }
+ }
+
+ return (\@uploaders, \@orig_uploaders);
+}
+
sub add_src_data {
my ($self, $src, $data) = @_;
$self->{src}{files} = \@files;
}
$self->{src}{directory} = $data{directory};
- my @uploaders;
- if ($data{maintainer} ||= '') {
- push @uploaders, [ split_name_mail( $data{maintainer} ) ];
- }
- if ($data{uploaders}) {
- my @up_tmp = split( /\s*,\s*/,
- $data{uploaders} );
- foreach my $up (@up_tmp) {
- if ($up ne $data{maintainer}) { # weed out duplicates
- push @uploaders, [ split_name_mail( $up ) ];
- }
- }
- }
- $self->{src}{uploaders} = \@uploaders;
+ my ($uploaders, $orig_uploaders) = $self->handle_maintainer_fields(\%data);
+ $self->{src}{uploaders} = $uploaders;
+ $self->{src}{orig_uploaders} = $orig_uploaders if @$orig_uploaders;
return 1;
}
return (exists($self->{provided_by}) && !exists($self->{versions}));
}
-our @TAKE_NEWEST = qw( description essential priority section subsection tag
- archive source source-version );
+our @TAKE_NEWEST = qw( description description-md5 essential priority section subsection tag
+ archive source source-version homepage maintainer original-maintainer uploaders);
our @STORE_ALL = qw( version source source-version installed-size size
- filename md5sum
+ filename md5sum sha1 sha256 task
origin bugs suite archive section );
our @DEP_FIELDS = qw( depends pre-depends recommends suggests enhances
provides conflicts );
($self->{package} eq $data->{package}) || return;
debug( "merge package $data->{package}/$data->{version}/$data->{architecture} into $self (".($self->{newest}||'').")", 2 ) if DEBUG;
+ (my $version = $data->{version}) =~ s/\+b\d+$//o; # strip binNMU number
unless ($self->{newest}) {
debug( "package $data->{package}/$data->{version}/$data->{architecture} is first to merge", 3 ) if DEBUG;
foreach my $key (@TAKE_NEWEST) {
foreach my $key (@DEP_FIELDS) {
$self->normalize_dependencies($key, $data);
}
- $self->{newest} = $data->{version};
+ $self->{newest} = $version;
return 1;
}
debug( "package $data->{package}/$data->{version}/$data->{architecture} is subsequent merge", 3 ) if DEBUG;
my $is_newest;
- my $cmp = version_cmp( $data->{version}, $self->{newest} );
- if ($is_newest = ($cmp > 0)) {
- $self->{newest} = $data->{version};
+ my $cmp = version_cmp( $version, $self->{newest} );
+ # packages from the central archive are preferred over all
+ # others with the same version number but from other archives
+ if ($is_newest = ($cmp > 0)
+ || (!$cmp && ($data->{archive} eq 'us') && ($self->{data}{archive} ne 'us'))) {
+ $self->{newest} = $version;
foreach my $key (@TAKE_NEWEST) {
$self->{data}{$key} = $data->{$key};
}
- } elsif (($cmp == 0) &&
- $self->{data}{archive} ne 'us') {
- #FIXME crude hack to prefer us archive over others
- $self->{data}{archive} = $data->{archive};
}
debug( "is_newest= ".($is_newest||0), 3 ) if DEBUG;
if (!$self->{versions}{$data->{architecture}}
my @v_str_arch;
foreach ( @versions ) {
push @v_str, [ $_, $versions->{$_} ];
- push @v_str_arch, "$_ [".join(', ', @{$versions->{$_}})."]";
+ push @v_str_arch, "$_ [".join(', ', sort @{$versions->{$_}})."]";
}
$v_str_arch = join( ", ", @v_str_arch );
$v_str = join( ", ", @versions );