use Deb::Versions;
use Packages::I18N::Locale;
use Packages::Search qw( :all );
-use Packages::CGI;
+use Packages::CGI qw( :DEFAULT );
use Packages::DB;
-use Packages::HTML qw(marker);
-use Packages::Config qw( $DBDIR $SEARCH_URL $SEARCH_PAGE
- @SUITES @ARCHIVES $ROOT );
-use Packages::HTML;
+use Packages::Config qw( $DBDIR @SUITES @ARCHIVES $ROOT );
sub do_search {
- my ($params, $opts, $html_header, $menu, $page_content) = @_;
+ my ($params, $opts, $html_header, $page_content) = @_;
$Params::Search::too_many_hits = 0;
if ($params->{errors}{keywords}) {
- fatal_error( _( "keyword not valid or missing" ) );
- } elsif (length($opts->{keywords}) < 2) {
- fatal_error( _( "keyword too short (keywords need to have at least two characters)" ) );
+ fatal_error( _g( "keyword not valid or missing" ) );
+ $opts->{keywords} = [];
+ } elsif (grep { length($_) < 2 } @{$opts->{keywords}}) {
+ fatal_error( _g( "keyword too short (keywords need to have at least two characters)" ) );
}
- $$menu = "";
-
- my $keyword = $opts->{keywords};
+ my @keywords = @{$opts->{keywords}};
my $searchon = $opts->{searchon};
+ $page_content->{search_keywords} = \@keywords;
- # for URL construction
- my $keyword_esc = uri_escape( $keyword );
- my $suites_param = join ',', @{$params->{values}{suite}{no_replace}};
- my $sections_param = join ',', @{$params->{values}{section}{no_replace}};
- my $archs_param = join ',', @{$params->{values}{arch}{no_replace}};
- $opts->{common_params} = "suite=$suites_param§ion=$sections_param&keywords=$keyword_esc&searchon=$searchon&arch=$archs_param";
-
- # for output
- my $keyword_enc = encode_entities $keyword || '';
- my $searchon_enc = encode_entities $searchon;
- my $suites_enc = encode_entities( join( ', ', @{$params->{values}{suite}{no_replace}} ) );
- my $sections_enc = encode_entities( join( ', ', @{$params->{values}{section}{no_replace}} ) );
- my $archs_enc = encode_entities( join( ', ', @{$params->{values}{arch}{no_replace}} ) );
-
my $st0 = new Benchmark;
my (@results, @non_results);
if ($searchon eq 'names') {
if ($opts->{source}) {
- do_names_search( $keyword, \%sources, $sp_obj,
+ do_names_search( [ @keywords ], \%sources, $sp_obj,
\&read_src_entry_all, $opts,
\@results, \@non_results );
} else {
- do_names_search( $keyword, \%packages, $p_obj,
+ do_names_search( [ @keywords ], \%packages, $p_obj,
\&read_entry_all, $opts,
\@results, \@non_results );
}
-# } elsif ($searchon eq 'contents') {
-# require "./search_contents.pl";
-# &contents($input);
} else {
- do_names_search( $keyword, \%packages, $p_obj,
+ do_names_search( [ @keywords ], \%packages, $p_obj,
\&read_entry_all, $opts,
\@results, \@non_results );
- do_fulltext_search( $keyword, "$DBDIR/descriptions.txt",
+ my $fts1 = new Benchmark;
+ do_xapian_search( [ @keywords ], "$DBDIR/xapian/",
\%did2pkg, \%packages,
\&read_entry_all, $opts,
\@results, \@non_results );
+ my $fts2 = new Benchmark;
+ my $fts_xapian = timediff($fts2,$fts1);
+ debug( "Fulltext search took ".timestr($fts_xapian) )
+ if DEBUG;
}
}
-
+
# use Data::Dumper;
-# debug( join( "", Dumper( \@results, \@non_results )) );
+# debug( join( "", Dumper( \@results, \@non_results )) ) if DEBUG;
my $st1 = new Benchmark;
my $std = timediff($st1, $st0);
- debug( "Search took ".timestr($std) );
-
- my $suite_wording = $suites_enc eq "all" ? "all suites"
- : "suite(s) <em>$suites_enc</em>";
- my $section_wording = $sections_enc eq 'all' ? "all sections"
- : "section(s) <em>$sections_enc</em>";
- my $arch_wording = $archs_enc eq 'any' ? "all architectures"
- : "architecture(s) <em>$archs_enc</em>";
- if ($searchon eq "names") {
- my $source_wording = $opts->{source} ? "source " : "";
- my $exact_wording = $opts->{exact} ? "named" : "that names contain";
- msg( "You have searched for ${source_wording}packages $exact_wording <em>$keyword_enc</em> in $suite_wording, $section_wording, and $arch_wording." );
- } else {
- my $exact_wording = $opts->{exact} ? "" : " (including subword matching)";
- msg( "You have searched for <em>$keyword_enc</em> in packages names and descriptions in $suite_wording, $section_wording, and $arch_wording$exact_wording." );
- }
+ debug( "Search took ".timestr($std) ) if DEBUG;
- if ($Packages::Search::too_many_hits) {
- error( sprintf( _( "Your search was too wide so we will only display exact matches. At least <em>%s</em> results have been omitted and will not be displayed. Please consider using a longer keyword or more keywords." ), $Packages::Search::too_many_hits ) );
- }
-
- if (!@Packages::CGI::fatal_errors && !@results) {
- if ($searchon eq "names") {
- unless (@non_results) {
- error( _( "Can't find that package." ) );
- } else {
- hint( _( "Can't find that package." )." ".
- sprintf( _( '<a href="%s">%s</a>'.
- " results have not been displayed due to the".
- " search parameters." ), "$SEARCH_URL/$keyword_esc" ,
- $#non_results+1 ) );
- }
-
- } else {
- if (($suites_enc eq 'all')
- && ($archs_enc eq 'any')
- && ($sections_enc eq 'all')) {
- error( _( "Can't find that string." ) );
- } else {
- error( sprintf( _( "Can't find that string, at least not in that suite (%s, section %s) and on that architecture (%s)." ),
- $suites_enc, $sections_enc, $archs_enc ) );
- }
-
- if ($opts->{exact}) {
- hint( sprintf( _( 'You have searched only for words exactly matching your keywords. You can try to search <a href="%s">allowing subword matching</a>.' ),
- encode_entities("$SEARCH_URL?exact=0&$opts->{common_params}") ) );
- }
- }
- hint( sprintf( _( 'You can try a different search on the <a href="%s">Packages search page</a>.' ), "$SEARCH_PAGE#search_packages" ) );
-
- }
+ $page_content->{too_many_hits} = $Packages::Search::too_many_hits;
+ #FIXME: non_results can't be compared to results since it is
+ # not normalized to unique packages
+ $page_content->{non_results} = scalar @non_results;
- %$html_header = ( title => _( 'Package Search Results' ) ,
- lang => $opts->{lang},
- title_tag => _( 'Debian Package Search Results' ),
- print_title => 1,
- print_search_field => 'packages',
- search_field_values => {
- keywords => $keyword_enc,
- searchon => $opts->{searchon_form},
- arch => $archs_enc,
- suite => $suites_enc,
- section => $sections_enc,
- exact => $opts->{exact},
- debug => $opts->{debug},
- },
- );
-
- $$page_content = '';
if (@results) {
my (%pkgs, %subsect, %sect, %archives, %desc, %binaries, %provided_by);
foreach (@results) {
my ($pkg_t, $archive, $suite, $arch, $section, $subsection,
$priority, $version, $desc) = @$_;
-
+
my ($pkg) = $pkg_t =~ m/^(.+)/; # untaint
if ($arch ne 'virtual') {
- my $real_archive;
- if ($archive =~ /^(security|non-US)$/) {
- $real_archive = $archive;
- $archive = 'us';
- }
-
- $pkgs{$pkg}{$suite}{$archive}{$version}{$arch} = 1;
- $subsect{$pkg}{$suite}{$archive}{$version} = $subsection;
- $sect{$pkg}{$suite}{$archive}{$version} = $section
- unless $section eq 'main';
- $archives{$pkg}{$suite}{$archive}{$version} = $real_archive
- if $real_archive;
-
- $desc{$pkg}{$suite}{$archive}{$version} = $desc;
+ $pkgs{$pkg}{$suite}{$version}{$arch} = 1;
+ $subsect{$pkg}{$suite}{$version} = $subsection;
+ $sect{$pkg}{$suite}{$version} = $section;
+ $archives{$pkg}{$suite}{$version} ||= $archive;
+
+ $desc{$pkg}{$suite}{$version} = $desc;
} else {
- $provided_by{$pkg}{$suite}{$archive} = [ split /\s+/, $desc ];
+ $provided_by{$pkg}{$suite} = [ split /\s+/, $desc ];
}
}
- my @pkgs = sort(keys %pkgs, keys %provided_by);
- $$page_content .= print_packages( \%pkgs, \@pkgs, $opts, $keyword,
- \&print_package, \%provided_by,
- \%archives, \%sect, \%subsect,
- \%desc );
+ my %uniq_pkgs = map { $_ => 1 } (keys %pkgs, keys %provided_by);
+ my @pkgs = sort keys %uniq_pkgs;
+ process_packages( $page_content, 'packages', \%pkgs, \@pkgs, $opts, \@keywords,
+ \&process_package, \%provided_by,
+ \%archives, \%sect, \%subsect,
+ \%desc );
} else { # unless $opts->{source}
foreach (@results) {
my ($pkg, $archive, $suite, $section, $subsection, $priority,
$version) = @$_;
-
+
my $real_archive = '';
if ($archive =~ /^(security|non-US)$/) {
$real_archive = $archive;
}
my @pkgs = sort keys %pkgs;
- $$page_content .= print_packages( \%pkgs, \@pkgs, $opts, $keyword,
- \&print_src_package, \%archives,
- \%sect, \%subsect, \%binaries );
+ process_packages( $page_content, 'src_packages', \%pkgs, \@pkgs, $opts, \@keywords,
+ \&process_src_package, \%archives,
+ \%sect, \%subsect, \%binaries );
} # else unless $opts->{source}
} # if @results
} # sub do_search
-sub print_packages {
- my ($pkgs, $pkgs_list, $opts, $keyword, $print_func, @func_args) = @_;
+sub process_packages {
+ my ($content, $target, $pkgs, $pkgs_list, $opts, $keywords, $print_func, @func_args) = @_;
+
+ my @categories;
+ $content->{results} = scalar @$pkgs_list;
- #my ($start, $end) = multipageheader( $input, scalar @pkgs, \%opts );
- my $str = '<div id="psearchres">';
- $str .= "<p>".sprintf( _( "Found <em>%s</em> matching packages." ),
- scalar @$pkgs_list )."</p>";
- #my $count = 0;
+ my $keyword;
+ $keyword = $keywords->[0] if @$keywords == 1;
my $have_exact;
- if (grep { $_ eq $keyword } @$pkgs_list) {
+ if ($keyword && grep { $_ eq $keyword } @$pkgs_list) {
$have_exact = 1;
- $str .= '<h2>'._( "Exact hits" ).'</h2>';
- $str .= &$print_func( $keyword, $pkgs->{$keyword}||{},
- map { $_->{$keyword}||{} } @func_args );
+ $categories[0]{name} = _g( "Exact hits" );
+
+ $categories[0]{$target} = [ &$print_func( $keyword, $pkgs->{$keyword}||{},
+ map { $_->{$keyword}||{} } @func_args ) ];
@$pkgs_list = grep { $_ ne $keyword } @$pkgs_list;
}
if (@$pkgs_list && (($opts->{searchon} ne 'names') || !$opts->{exact})) {
- $str .= '<h2>'._( 'Other hits' ).'</h2>'
- if $have_exact;
+ my %cat;
+ $cat{name} = _g( 'Other hits' ) if $have_exact;
+ $cat{packages} = [];
foreach my $pkg (@$pkgs_list) {
- #$count++;
- #next if $count < $start or $count > $end;
- $str .= &$print_func( $pkg, $pkgs->{$pkg}||{},
- map { $_->{$pkg}||{} } @func_args );
+ push @{$cat{$target}}, &$print_func( $pkg, $pkgs->{$pkg}||{},
+ map { $_->{$pkg}||{} } @func_args );
}
+ push @categories, \%cat;
} elsif (@$pkgs_list) {
- $str .= "<p>".sprintf( _( '<a href="%s">%s</a> results have not been displayed because you requested only exact matches.' ),
- encode_entities("$SEARCH_URL?exact=0&$opts->{common_params}"),
- scalar @$pkgs_list )."</p>";
+ $content->{skipped} = scalar @$pkgs_list;
}
- $str .= '</div>';
- return $str;
+ $content->{categories} = \@categories;
}
-sub print_package {
+sub process_package {
my ($pkg, $pkgs, $provided_by, $archives, $sect, $subsect, $desc) = @_;
- my $str = '<h3>'.sprintf( _( 'Package %s' ), $pkg ).'</h3>';
- $str .= '<ul>';
+ my %pkg = ( pkg => $pkg,
+ suites => [] );
+
foreach my $suite (@SUITES) {
- foreach my $archive (@ARCHIVES) {
- next if $archive eq 'security';
- next if $archive eq 'non-US';
- my $path = $suite.(($archive ne 'us')?"/$archive":'');
- if (exists $pkgs->{$suite}{$archive}) {
- my %archs_printed;
- my @versions = version_sort keys %{$pkgs->{$suite}{$archive}};
- my $origin_str = "";
- if ($sect->{$suite}{$archive}{$versions[0]}) {
- $origin_str .= " ".marker($sect->{$suite}{$archive}{$versions[0]});
- }
- $str .= sprintf( "<li><a href=\"$ROOT/%s/%s\">%s</a> (%s): %s %s\n",
- $path, $pkg, $path, $subsect->{$suite}{$archive}{$versions[0]},
- $desc->{$suite}{$archive}{$versions[0]}, $origin_str );
+ my %suite = ( suite => $suite );
+ if (exists $pkgs->{$suite}) {
+ my %archs_printed;
+ my @versions = version_sort keys %{$pkgs->{$suite}};
+ $suite{section} = $sect->{$suite}{$versions[0]};
+ $suite{subsection} = $subsect->{$suite}{$versions[0]};
+ $suite{desc} = $desc->{$suite}{$versions[0]};
+ $suite{versions} = [];
- foreach my $v (@versions) {
- my $archive_str = "";
- if ($archives->{$suite}{$archive}{$v}) {
- $archive_str .= " ".marker($archives->{$suite}{$archive}{$v});
- }
+ foreach my $v (@versions) {
+ my %version;
+ $version{version} = $v;
+ $version{archive} = $archives->{$suite}{$v};
- my @archs_to_print = grep { !$archs_printed{$_} } sort keys %{$pkgs->{$suite}{$archive}{$v}};
- $str .= sprintf( "<br>%s$archive_str: %s\n",
- $v, join (" ", @archs_to_print ))
- if @archs_to_print;
- $archs_printed{$_}++ foreach @archs_to_print;
- }
- if (my $p = $provided_by->{$suite}{$archive}) {
- $str .= '<br>'._( 'also provided by: ' ).
- join( ', ', map { "<a href=\"$ROOT/$path/$_\">$_</a>" } @$p);
- }
- $str .= "</li>\n";
- } elsif (my $p = $provided_by->{$suite}{$archive}) {
- $str .= sprintf( "<li><a href=\"$ROOT/%s/%s\">%s</a>: Virtual package<br>",
- $path, $pkg, $path );
- $str .= _( 'provided by: ' ).
- join( ', ', map { "<a href=\"$ROOT/$path/$_\">$_</a>" } @$p);
+ $version{architectures} = [ grep { !$archs_printed{$_} } sort keys %{$pkgs->{$suite}{$v}} ];
+ push @{$suite{versions}}, \%version if @{$version{architectures}};
+
+ $archs_printed{$_}++ foreach @{$version{architectures}};
+ }
+ if (my $p = $provided_by->{$suite}) {
+ $suite{providers} = $p;
}
+ } elsif (my $p = $provided_by->{$suite}) {
+ $suite{desc} = _g('Virtual package');
+ $suite{providers} = $p;
}
+ push @{$pkg{suites}}, \%suite if $suite{versions} || $suite{providers};
}
- $str .= "</ul>\n";
- return $str;
+
+ return \%pkg;
}
-sub print_src_package {
+sub process_src_package {
my ($pkg, $pkgs, $archives, $sect, $subsect, $binaries) = @_;
- my $str = '<h3>'.sprintf( _( 'Source package %s' ), $pkg ).'</h3>';
- $str .= "<ul>\n";
+ my %pkg = ( pkg => $pkg,
+ origins => [] );
+
foreach my $suite (@SUITES) {
foreach my $archive (@ARCHIVES) {
if (exists $pkgs->{$suite}{$archive}) {
- my $origin_str = "";
- if ($sect->{$suite}{$archive}{source}) {
- $origin_str .= " ".marker($sect->{$suite}{$archive}{source});
- }
- if ($archives->{$suite}{$archive}{source}) {
- $origin_str .= " ".marker($archives->{$suite}{$archive}{source});
- }
- $str .= sprintf( "<li><a href=\"$ROOT/%s/source/%s\">%s</a> (%s): %s %s",
- $suite.(($archive ne 'us')?"/$archive":''), $pkg, $suite.(($archive ne 'us')?"/$archive":''), $subsect->{$suite}{$archive}{source},
- $pkgs->{$suite}{$archive}, $origin_str );
-
- $str .= "<br>"._( 'Binary packages: ' );
- my @bp_links;
- foreach my $bp (@{$binaries->{$suite}{$archive}}) {
- my $bp_link = sprintf( "<a href=\"$ROOT/%s/%s\">%s</a>",
- $suite.(($archive ne 'us')?"/$archive":''), uri_escape( $bp ), $bp );
- push @bp_links, $bp_link;
- }
- $str .= join( ", ", @bp_links );
- $str .= "</li>\n";
+ my %origin;
+ $origin{version} = $pkgs->{$suite}{$archive};
+ $origin{suite} = $suite;
+ $origin{archive} = $archive;
+ $origin{section} = $sect->{$suite}{$archive}{source};
+ $origin{subsection} = $subsect->{$suite}{$archive}{source};
+ $origin{real_archive} = $archives->{$suite}{$archive}{source};
+
+ $origin{binaries} = $binaries->{$suite}{$archive};
+ push @{$pkg{origins}}, \%origin;
}
}
}
- $str .= "</ul>\n";
- return $str;
+
+ return \%pkg;
}
1;