Move $debug_allowed to CGI as a real constant and modify all debug() calls

[deb/packages.git] / cgi-bin / dispatcher.pl

diff --git a/cgi-bin/dispatcher.pl b/cgi-bin/dispatcher.pl
index 3198d2a81e48fb7d20ec03ed8eaea3dfc755ceb4..a4b3e3960aec19ab46735e4d6bd9b977549211ee 100755 (executable)
--- a/cgi-bin/dispatcher.pl
+++ b/cgi-bin/dispatcher.pl
@@ -54,9 +54,7 @@ if ($ARGV[0] && ($ARGV[0] eq 'php')) {
 
 my $pet0 = new Benchmark;
 my $tet0 = new Benchmark;
-# use this to disable debugging in production mode completly
-my $debug_allowed = 1;
-my $debug = $debug_allowed && $input->param("debug");
+my $debug = DEBUG && $input->param("debug");
 $debug = 0 if !defined($debug) || $debug !~ /^\d+$/o;
 $Packages::CGI::debug = $debug;
 
@@ -86,10 +84,10 @@ if (my $path = $input->path_info() || $input->param('PATH_INFO')) {
        shift @components;
        $what_to_do = 'search';
        # Done
-       fatal_error( _( "search doesn't take any more path elements" ) )
+       fatal_error( _g( "search doesn't take any more path elements" ) )
            if @components > 0;
     } elsif (@components == 0) {
-       fatal_error( _( "We're supposed to display the homepage here, instead of getting dispatch.pl" ) );
+       fatal_error( _g( "We're supposed to display the homepage here, instead of getting dispatch.pl" ) );
     } elsif (@components == 1) {
        $what_to_do = 'search';
     } else {
@@ -114,7 +112,7 @@ if (my $path = $input->path_info() || $input->param('PATH_INFO')) {
        sub set_param_once {
            my ($cgi, $params_set, $key, $val) = @_;
            if ($params_set->{$key}++) {
-               fatal_error( sprintf( _( "%s set more than once in path" ), $key ) );
+               fatal_error( sprintf( _g( "%s set more than once in path" ), $key ) );
            } else {
                $cgi->param( $key, $val );
            }
@@ -144,7 +142,7 @@ if (my $path = $input->path_info() || $input->param('PATH_INFO')) {
        @components = @tmp;
 
        if (@components > 1) {
-           fatal_error( sprintf( _( "two or more packages specified (%s)" ), "@components" ) );
+           fatal_error( sprintf( _g( "two or more packages specified (%s)" ), "@components" ) );
        }
     } # else if (@components == 1)
     
@@ -192,14 +190,14 @@ my %params = Packages::Search::parse_params( $input, \%params_def, \%opts );
 my $locale = get_locale($opts{lang});
 my $charset = get_charset($opts{lang});
 setlocale ( LC_ALL, $locale )
-    or do { debug( "couldn't set locale $locale, using default" );
+    or do { debug( "couldn't set locale $locale, using default" ) if DEBUG;
            setlocale( LC_ALL, get_locale() )
                or do {
-                   debug( "couldn't set default locale either" );
+                   debug( "couldn't set default locale either" ) if DEBUG;
                    setlocale( LC_ALL, "C" );
                };
        };
-debug( "locale=$locale charset=$charset", 2 );
+debug( "locale=$locale charset=$charset", 2 ) if DEBUG;
 
 $opts{h_suites} = { map { $_ => 1 } @suites };
 $opts{h_sections} = { map { $_ => 1 } @sections };
@@ -220,7 +218,7 @@ if ($opts{searchon} eq 'contents' or $opts{searchon} eq 'filenames') {
 
 my $pet1 = new Benchmark;
 my $petd = timediff($pet1, $pet0);
-debug( "Parameter evaluation took ".timestr($petd) );
+debug( "Parameter evaluation took ".timestr($petd) ) if DEBUG;
 
 print $input->header( -charset => $charset );
 
@@ -230,12 +228,12 @@ unless (@Packages::CGI::fatal_errors) {
     &{"do_$what_to_do"}( \%params, \%opts, \%html_header,
                         \$menu, \$page_content );
 } else {
-    %html_header = ( title => _('Error'),
+    %html_header = ( title => _g('Error'),
                     lang => $opts{lang},
                     print_title => 1,
                     print_search_field => 'packages',
                     search_field_values => { 
-                        keywords => _('search for a package'),
+                        keywords => _g('search for a package'),
                         searchon => 'default',
                         arch => 'any',
                         suite => 'all',
@@ -252,7 +250,7 @@ print $menu||'';
 print_errors();
 print_hints();
 print_msgs();
-print_debug();
+print_debug() if DEBUG;
 print_notes();
 
 unless (@Packages::CGI::fatal_errors) {