From cc8d5d2a45c8e02b6c7b9c0f8c1afa9aca2732ae Mon Sep 17 00:00:00 2001 From: miniduikboot Date: Mon, 10 Jan 2022 20:47:19 +0100 Subject: [PATCH] Remove name length/validity checks from JoinGame Length and validity are checked also checked by the anticheat. In case Impostor goes out of sync with the allowed characters again, this can just be fixed by disabling the Anticheat. Check for NullOrWhiteSpace is kept because an empty username could be annoying --- src/Impostor.Server/Net/Manager/ClientManager.cs | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/Impostor.Server/Net/Manager/ClientManager.cs b/src/Impostor.Server/Net/Manager/ClientManager.cs index 37ae45e..d25e5a1 100644 --- a/src/Impostor.Server/Net/Manager/ClientManager.cs +++ b/src/Impostor.Server/Net/Manager/ClientManager.cs @@ -90,15 +90,7 @@ namespace Impostor.Server.Net.Manager return; } - if (name.Length > 10) - { - using var packet = MessageWriter.Get(MessageType.Reliable); - Message01JoinGameS2C.SerializeError(packet, false, DisconnectReason.Custom, DisconnectMessages.UsernameLength); - await connection.SendAsync(packet); - return; - } - - if (string.IsNullOrWhiteSpace(name) || !name.All(TextBox.IsCharAllowed)) + if (string.IsNullOrWhiteSpace(name)) { using var packet = MessageWriter.Get(MessageType.Reliable); Message01JoinGameS2C.SerializeError(packet, false, DisconnectReason.Custom, DisconnectMessages.UsernameIllegalCharacters); -- 2.39.5