From abca669f5c4eb8c3edea55ff68a2611a43e33390 Mon Sep 17 00:00:00 2001
From: JamJar00 <jamster.30@btinternet.com>
Date: Sat, 14 May 2016 20:54:06 +0100
Subject: [PATCH] Removed some todos

---
 Hazel/UdpClientConnection.cs    | 14 +++++++++++---
 Hazel/UdpConnection.Reliable.cs | 14 +++++++-------
 Hazel/UdpConnection.cs          |  2 +-
 Hazel/UdpConnectionListener.cs  |  2 +-
 Performance1.psess              | 21 +++++++++++++++++++++
 5 files changed, 41 insertions(+), 12 deletions(-)
 create mode 100644 Performance1.psess

diff --git a/Hazel/UdpClientConnection.cs b/Hazel/UdpClientConnection.cs
index 5194cc5..dbf4820 100644
--- a/Hazel/UdpClientConnection.cs
+++ b/Hazel/UdpClientConnection.cs
@@ -99,11 +99,19 @@ namespace Hazel
 
                 State = ConnectionState.Connecting;
 
+                //Calculate local end point
+                EndPoint localEndPoint;
+                if (nep.EndPoint is IPEndPoint)
+                    localEndPoint = new IPEndPoint(((IPEndPoint)nep.EndPoint).Address, 0);
+                else if (nep.EndPoint is IPEndPoint)
+                    localEndPoint = new DnsEndPoint(((DnsEndPoint)nep.EndPoint).Host, 0);
+                else
+                    throw new ArgumentException("Can only connect using an IPEndPoint or DnsEndpoint");
+
                 //Begin listening
                 try
                 {
-                    //TODO should that really be IPAddress.Any?
-                    socket.Bind(new IPEndPoint(IPAddress.Any, 0));
+                    socket.Bind(localEndPoint);
                 }
                 catch (SocketException e)
                 {
@@ -179,7 +187,7 @@ namespace Hazel
             byte[] buffer = HandleReceive(dataBuffer, bytesReceived);
             SendOption sendOption = (SendOption)dataBuffer[0];
 
-            //TODO may possibly get better performance with above/below swapped and block copy added
+            //TODO may get better performance with Handle receive after and block copy call added
 
             //Begin receiving again
             try
diff --git a/Hazel/UdpConnection.Reliable.cs b/Hazel/UdpConnection.Reliable.cs
index d69b393..da02455 100644
--- a/Hazel/UdpConnection.Reliable.cs
+++ b/Hazel/UdpConnection.Reliable.cs
@@ -9,7 +9,9 @@ using System.Threading.Tasks;
 namespace Hazel
 {
     partial class UdpConnection
-    {//TODO recycle dataevents and things?
+    {
+        //TODO recycle dataevents and things?
+        
         /// <summary>
         ///     The starting timeout, in miliseconds, at which data will be resent.
         /// </summary>
@@ -24,11 +26,6 @@ namespace Hazel
         /// </summary>
         volatile ushort lastIDAllocated;
 
-        /// <summary>
-        ///     The number of items to remember we have received before overwriting.
-        /// </summary>
-        private readonly int receiveCapacity = 4096;
-
         /// <summary>
         ///     The packets of data that have been transmitted reliably and not acknowledged.
         /// </summary>
@@ -136,9 +133,12 @@ namespace Hazel
             //Handle reliableness!
             lock (reliableDataPacketsMissing)
             {
+                //TODO Looping of IDs
+                //      Currently when ID loops all packets will be discarded as ID will be less than reliableReceiveLast
+                //      And wont be in reliableDataPacketsMissing.
+
                 //If the ID <= reliableReceiveLast it might be something we're missing
                 //HasReceivedSomething handles the edge case of reliableReceiveLast = 0 & ID = 0
-                //TODO Looping of IDs
                 if (id <= reliableReceiveLast && hasReceivedSomething)
                 {
                     //See if we're missing it, else this packet is a duplicate
diff --git a/Hazel/UdpConnection.cs b/Hazel/UdpConnection.cs
index 69628ea..4e880c0 100644
--- a/Hazel/UdpConnection.cs
+++ b/Hazel/UdpConnection.cs
@@ -71,7 +71,7 @@ namespace Hazel
             Buffer.BlockCopy(data, 0, bytes, bytes.Length - data.Length, data.Length);
 
             //Inform keepalive not to send for a while
-            ResetKeepAliveTimer();      //TODO keepalive tests
+            ResetKeepAliveTimer();
 
             //Write to connection
             WriteBytesToConnection(bytes);
diff --git a/Hazel/UdpConnectionListener.cs b/Hazel/UdpConnectionListener.cs
index b03f160..da2c06b 100644
--- a/Hazel/UdpConnectionListener.cs
+++ b/Hazel/UdpConnectionListener.cs
@@ -5,7 +5,7 @@ using System.Net;
 using System.Net.Sockets;
 using System.Text;
 using System.Threading.Tasks;
-//TODO complete trawl through for thread safety, everywhere
+
 /* 
 * Copyright (C) Jamie Read - All Rights Reserved
 * Unauthorized copying of this file, via any medium is strictly prohibited
diff --git a/Performance1.psess b/Performance1.psess
new file mode 100644
index 0000000..7dc9d39
--- /dev/null
+++ b/Performance1.psess
@@ -0,0 +1,21 @@
+<VSPerformanceSession Version="1.00">
+  <Options>
+    <CollectionMethod>Sampling</CollectionMethod>
+    <AllocationMethod>None</AllocationMethod>
+    <AddReport>true</AddReport>
+    <UniqueReport>Timestamp</UniqueReport>
+    <SamplingMethod>Cycles</SamplingMethod>
+    <CycleCount>10000000</CycleCount>
+    <PageFaultCount>10</PageFaultCount>
+    <SysCallCount>10</SysCallCount>
+    <SamplingCounter PlatformID="00000000" CounterID="0000000000000000" ReloadValue="000000000000000a" />
+    <RelocateBinaries>false</RelocateBinaries>
+    <HardwareCounters EnableHWCounters="false" />
+  </Options>
+  <PreinstrumentEvent>
+    <InstrEventExclude>false</InstrEventExclude>
+  </PreinstrumentEvent>
+  <PostinstrumentEvent>
+    <InstrEventExclude>false</InstrEventExclude>
+  </PostinstrumentEvent>
+</VSPerformanceSession>
-- 
2.39.5