From 066eca09ee2b7369ced8f3ea5bfa385d578285ae Mon Sep 17 00:00:00 2001 From: miniduikboot Date: Thu, 8 Aug 2024 21:31:07 +0200 Subject: [PATCH] Add scene param to forbidden scene log statement I'm seeing multiple warnings in my server log about forbidden scene changes. Unfortunately this warning does not include the actual scene that was triggering the issue, which makes diagnosis/remediation difficult. Additionally change this logging call to use names suitable for structured logging. --- src/Impostor.Server/Net/State/Game.Data.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Impostor.Server/Net/State/Game.Data.cs b/src/Impostor.Server/Net/State/Game.Data.cs index 65632d5..5f0e56c 100644 --- a/src/Impostor.Server/Net/State/Game.Data.cs +++ b/src/Impostor.Server/Net/State/Game.Data.cs @@ -245,9 +245,10 @@ namespace Impostor.Server.Net.State if (scene != "OnlineGame") { _logger.LogWarning( - "Player {0} ({1}) tried to send SceneChangeFlag with disallowed scene.", + "Player {PlayerName} ({ClientId}) tried to send SceneChangeFlag with disallowed scene \"{Scene}\".", sender.Client.Name, - sender.Client.Id); + sender.Client.Id, + scene); return false; } -- 2.39.5