From: miniduikboot <mini@duikbo.at>
Date: Mon, 10 Jan 2022 19:47:19 +0000 (+0100)
Subject: Remove name length/validity checks from JoinGame
X-Git-Tag: v1.7.0~13^2~1
X-Git-Url: https://git.deb.at/?a=commitdiff_plain;h=cc8d5d2;p=rhonda%2Fimpostor.git

Remove name length/validity checks from JoinGame

Length and validity are checked also checked by the anticheat. In case
Impostor goes out of sync with the allowed characters again, this can
just be fixed by disabling the Anticheat.

Check for NullOrWhiteSpace is kept because an empty username could be annoying
---

diff --git a/src/Impostor.Server/Net/Manager/ClientManager.cs b/src/Impostor.Server/Net/Manager/ClientManager.cs
index 37ae45e..d25e5a1 100644
--- a/src/Impostor.Server/Net/Manager/ClientManager.cs
+++ b/src/Impostor.Server/Net/Manager/ClientManager.cs
@@ -90,15 +90,7 @@ namespace Impostor.Server.Net.Manager
                 return;
             }
 
-            if (name.Length > 10)
-            {
-                using var packet = MessageWriter.Get(MessageType.Reliable);
-                Message01JoinGameS2C.SerializeError(packet, false, DisconnectReason.Custom, DisconnectMessages.UsernameLength);
-                await connection.SendAsync(packet);
-                return;
-            }
-
-            if (string.IsNullOrWhiteSpace(name) || !name.All(TextBox.IsCharAllowed))
+            if (string.IsNullOrWhiteSpace(name))
             {
                 using var packet = MessageWriter.Get(MessageType.Reliable);
                 Message01JoinGameS2C.SerializeError(packet, false, DisconnectReason.Custom, DisconnectMessages.UsernameIllegalCharacters);