From: js6pak Date: Mon, 5 Jul 2021 19:13:56 +0000 (+0200) Subject: Fix warnings in Impostor.Benchmarks X-Git-Tag: v1.5.0~3^2 X-Git-Url: https://git.deb.at/?a=commitdiff_plain;h=c6aa596e3bbce55f560d2475613abd252838cd6d;p=rhonda%2Fimpostor.git Fix warnings in Impostor.Benchmarks --- diff --git a/src/Impostor.Benchmarks/Data/MessageReader_Bytes_Pooled.cs b/src/Impostor.Benchmarks/Data/MessageReader_Bytes_Pooled.cs index 3c88ffb..814c16f 100644 --- a/src/Impostor.Benchmarks/Data/MessageReader_Bytes_Pooled.cs +++ b/src/Impostor.Benchmarks/Data/MessageReader_Bytes_Pooled.cs @@ -9,7 +9,7 @@ namespace Impostor.Benchmarks.Data { public class MessageReader_Bytes_Pooled { - private static ConcurrentQueue _readers; + private static readonly ConcurrentQueue _readers; static MessageReader_Bytes_Pooled() { diff --git a/src/Impostor.Benchmarks/Data/MessageWriter.cs b/src/Impostor.Benchmarks/Data/MessageWriter.cs index b55b797..e1c346c 100644 --- a/src/Impostor.Benchmarks/Data/MessageWriter.cs +++ b/src/Impostor.Benchmarks/Data/MessageWriter.cs @@ -11,7 +11,7 @@ namespace Impostor.Benchmarks.Data { public MessageType SendOption { get; private set; } - private Stack messageStarts = new Stack(); + private readonly Stack _messageStarts = new Stack(); public MessageWriter(byte[] buffer) { @@ -78,7 +78,7 @@ namespace Impostor.Benchmarks.Data /// public void StartMessage(byte typeFlag) { - messageStarts.Push(this.Position); + _messageStarts.Push(this.Position); this.Position += 2; // Skip for size this.Write(typeFlag); } @@ -86,7 +86,7 @@ namespace Impostor.Benchmarks.Data /// public void EndMessage() { - var lastMessageStart = messageStarts.Pop(); + var lastMessageStart = _messageStarts.Pop(); var length = (ushort)(this.Position - lastMessageStart - 3); // Minus length and type byte this.Buffer[lastMessageStart] = (byte)length; this.Buffer[lastMessageStart + 1] = (byte)(length >> 8); @@ -95,13 +95,13 @@ namespace Impostor.Benchmarks.Data /// public void CancelMessage() { - this.Position = this.messageStarts.Pop(); + this.Position = this._messageStarts.Pop(); this.Length = this.Position; } public void Clear(MessageType sendOption) { - this.messageStarts.Clear(); + this._messageStarts.Clear(); this.SendOption = sendOption; this.Buffer[0] = (byte)sendOption; switch (sendOption) @@ -293,7 +293,7 @@ namespace Impostor.Benchmarks.Data this.Write(msg.Buffer, offset, msg.Length - offset); } - public unsafe static bool IsLittleEndian() + public static unsafe bool IsLittleEndian() { byte b; unsafe