From: miniduikboot <mini@duikbo.at>
Date: Thu, 8 Aug 2024 19:31:07 +0000 (+0200)
Subject: Add scene param to forbidden scene log statement
X-Git-Tag: v1.10.0~8
X-Git-Url: https://git.deb.at/?a=commitdiff_plain;h=066eca09ee2b7369ced8f3ea5bfa385d578285ae;p=rhonda%2Fimpostor.git

Add scene param to forbidden scene log statement

I'm seeing multiple warnings in my server log about forbidden scene
changes. Unfortunately this warning does not include the actual scene
that was triggering the issue, which makes diagnosis/remediation difficult.

Additionally change this logging call to use names suitable for
structured logging.
---

diff --git a/src/Impostor.Server/Net/State/Game.Data.cs b/src/Impostor.Server/Net/State/Game.Data.cs
index 65632d5..5f0e56c 100644
--- a/src/Impostor.Server/Net/State/Game.Data.cs
+++ b/src/Impostor.Server/Net/State/Game.Data.cs
@@ -245,9 +245,10 @@ namespace Impostor.Server.Net.State
                         if (scene != "OnlineGame")
                         {
                             _logger.LogWarning(
-                                "Player {0} ({1}) tried to send SceneChangeFlag with disallowed scene.",
+                                "Player {PlayerName} ({ClientId}) tried to send SceneChangeFlag with disallowed scene \"{Scene}\".",
                                 sender.Client.Name,
-                                sender.Client.Id);
+                                sender.Client.Id,
+                                scene);
                             return false;
                         }