]> git.deb.at Git - rhonda/impostor.git/commitdiff
Fix warnings in Impostor.Benchmarks
authorjs6pak <kubastaron@hotmail.com>
Mon, 5 Jul 2021 19:13:56 +0000 (21:13 +0200)
committerjs6pak <kubastaron@hotmail.com>
Mon, 5 Jul 2021 19:13:56 +0000 (21:13 +0200)
src/Impostor.Benchmarks/Data/MessageReader_Bytes_Pooled.cs
src/Impostor.Benchmarks/Data/MessageWriter.cs

index 3c88ffb7cf8cbbba20f911a5c49eaca11e965f25..814c16f7b54026c5921e7935395345fb64d1d35d 100644 (file)
@@ -9,7 +9,7 @@ namespace Impostor.Benchmarks.Data
 {
     public class MessageReader_Bytes_Pooled
     {
-        private static ConcurrentQueue<MessageReader_Bytes_Pooled> _readers;
+        private static readonly ConcurrentQueue<MessageReader_Bytes_Pooled> _readers;
 
         static MessageReader_Bytes_Pooled()
         {
index b55b7970e4a76fd93f8bf3fb7e9b6d67cd8e279d..e1c346c760e25258dc4fb5f87e6f701eddc3ced0 100644 (file)
@@ -11,7 +11,7 @@ namespace Impostor.Benchmarks.Data
     {
         public MessageType SendOption { get; private set; }
 
-        private Stack<int> messageStarts = new Stack<int>();
+        private readonly Stack<int> _messageStarts = new Stack<int>();
 
         public MessageWriter(byte[] buffer)
         {
@@ -78,7 +78,7 @@ namespace Impostor.Benchmarks.Data
         ///
         public void StartMessage(byte typeFlag)
         {
-            messageStarts.Push(this.Position);
+            _messageStarts.Push(this.Position);
             this.Position += 2; // Skip for size
             this.Write(typeFlag);
         }
@@ -86,7 +86,7 @@ namespace Impostor.Benchmarks.Data
         ///
         public void EndMessage()
         {
-            var lastMessageStart = messageStarts.Pop();
+            var lastMessageStart = _messageStarts.Pop();
             var length = (ushort)(this.Position - lastMessageStart - 3); // Minus length and type byte
             this.Buffer[lastMessageStart] = (byte)length;
             this.Buffer[lastMessageStart + 1] = (byte)(length >> 8);
@@ -95,13 +95,13 @@ namespace Impostor.Benchmarks.Data
         ///
         public void CancelMessage()
         {
-            this.Position = this.messageStarts.Pop();
+            this.Position = this._messageStarts.Pop();
             this.Length = this.Position;
         }
 
         public void Clear(MessageType sendOption)
         {
-            this.messageStarts.Clear();
+            this._messageStarts.Clear();
             this.SendOption = sendOption;
             this.Buffer[0] = (byte)sendOption;
             switch (sendOption)
@@ -293,7 +293,7 @@ namespace Impostor.Benchmarks.Data
             this.Write(msg.Buffer, offset, msg.Length - offset);
         }
 
-        public unsafe static bool IsLittleEndian()
+        public static unsafe bool IsLittleEndian()
         {
             byte b;
             unsafe