more comments sent over discord pm's

diff --git a/src/Impostor.Server/Net/Inner/Objects/GameManager/InnerGameManager.cs b/src/Impostor.Server/Net/Inner/Objects/GameManager/InnerGameManager.cs
index 3cc95147e10888edba8cba0509060eead33dbcf1..6281c163de315d1f1d72ba159425ec12842b9910 100644 (file)
--- a/src/Impostor.Server/Net/Inner/Objects/GameManager/InnerGameManager.cs
+++ b/src/Impostor.Server/Net/Inner/Objects/GameManager/InnerGameManager.cs
@@ -66,7 +66,7 @@ internal abstract class InnerGameManager : InnerNetObject, IInnerGameManager
         throw new System.NotImplementedException();
     }
 
-    public override ValueTask DeserializeAsync(IClientPlayer sender, IClientPlayer? target, IMessageReader reader, bool initialState)
+    public override async ValueTask DeserializeAsync(IClientPlayer sender, IClientPlayer? target, IMessageReader reader, bool initialState)
     {
         while (reader.Position < reader.Length)
         {
@@ -80,7 +80,7 @@ internal abstract class InnerGameManager : InnerNetObject, IInnerGameManager
 
             var component = this._logicComponents[tag];
 
-            component.Deserialize(innerReader, initialState);
+            await component.DeserializeAsync(innerReader, initialState);
 
             if (innerReader.Position < innerReader.Length)
             {
@@ -92,7 +92,5 @@ internal abstract class InnerGameManager : InnerNetObject, IInnerGameManager
                     innerReader.Length);
             }
         }
-
-        return ValueTask.CompletedTask;
     }
 }

diff --git a/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/GameLogicComponent.cs b/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/GameLogicComponent.cs
index cb1f5f47d78166ef063eb74b62d9f213f18e88bc..3847b53b76fad81833f7e05fccd8607ad8742cfa 100644 (file)
--- a/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/GameLogicComponent.cs
+++ b/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/GameLogicComponent.cs
@@ -16,7 +16,7 @@ internal abstract class GameLogicComponent
         throw new NotImplementedException();
     }
 
-    public virtual ValueTask Deserialize(IMessageReader reader, bool initialState)
+    public virtual ValueTask DeserializeAsync(IMessageReader reader, bool initialState)
     {
         return default;
     }

diff --git a/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/HideAndSeek/LogicGameFlowHnS.cs b/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/HideAndSeek/LogicGameFlowHnS.cs
index 31ca33655afbb27cf690162dbeaf115bdcf980ef..c26bf5230361c1102c6caff8f50200d193baa0b3 100644 (file)
--- a/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/HideAndSeek/LogicGameFlowHnS.cs
+++ b/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/HideAndSeek/LogicGameFlowHnS.cs
@@ -9,7 +9,7 @@ internal class LogicGameFlowHnS : LogicGameFlow, ILogicGameFlowHnS
 
     public float CurrentHideTime { get; private set; }
 
-    public override ValueTask Deserialize(IMessageReader reader, bool initialState)
+    public override ValueTask DeserializeAsync(IMessageReader reader, bool initialState)
     {
         var num = reader.ReadSingle();
 

diff --git a/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/LogicOptions.cs b/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/LogicOptions.cs
index 626b1d963742b909bae7e4c122c5c8dd4baf5de1..f444582703dd4a014679893ebe1f3250ea3e3159 100644 (file)
--- a/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/LogicOptions.cs
+++ b/src/Impostor.Server/Net/Inner/Objects/GameManager/Logic/LogicOptions.cs
@@ -23,12 +23,12 @@ internal abstract class LogicOptions : GameLogicComponent
         return true;
     }
 
-    public override async ValueTask Deserialize(IMessageReader reader, bool initialState)
+    public override async ValueTask DeserializeAsync(IMessageReader reader, bool initialState)
     {
         GameOptionsFactory.DeserializeInto(reader, _game.Options);
         await _eventManager.CallAsync(new GameOptionsChangedEvent(
             _game,
-            Api.Events.IGameOptionsChangedEvent.ChangeReason.Host)
-        );
+            Api.Events.IGameOptionsChangedEvent.ChangeReason.Host
+        ));
     }
 }

diff --git a/src/Impostor.Server/Net/State/Game.Api.cs b/src/Impostor.Server/Net/State/Game.Api.cs
index bc5da053ab6103f31577200a2b972659f4dc4182..e3fc4cb57b917600186e046cf14ee30b221b9bb8 100644 (file)
--- a/src/Impostor.Server/Net/State/Game.Api.cs
+++ b/src/Impostor.Server/Net/State/Game.Api.cs
@@ -76,8 +76,8 @@ namespace Impostor.Server.Net.State
                     _alreadyCallingOptionsChangedEvent = true;
                     await _eventManager.CallAsync(new GameOptionsChangedEvent(
                         this,
-                        Api.Events.IGameOptionsChangedEvent.ChangeReason.Api)
-                    );
+                        Api.Events.IGameOptionsChangedEvent.ChangeReason.Api
+                    ));
                 }
                 finally
                 {