Dispose message readers

diff --git a/src/Impostor.Server/Net/Hazel/HazelConnection.cs b/src/Impostor.Server/Net/Hazel/HazelConnection.cs
index 1d6f35c475a4044257b05ac0279f73f15c8eb5bf..45d2be82741ba43f93297328111096e95b2b92ee 100644 (file)
--- a/src/Impostor.Server/Net/Hazel/HazelConnection.cs
+++ b/src/Impostor.Server/Net/Hazel/HazelConnection.cs
@@ -64,7 +64,10 @@ namespace Impostor.Server.Net.Hazel
                     break;
                 }
 
-                await Client.HandleMessageAsync(e.Message.ReadMessage(), e.Type);
+                using (var message = e.Message.ReadMessage())
+                {
+                    await Client.HandleMessageAsync(message, e.Type);
+                }
             }
         }
     }

diff --git a/src/Impostor.Server/Net/Inner/Objects/InnerGameData.cs b/src/Impostor.Server/Net/Inner/Objects/InnerGameData.cs
index 7f71b1f497789e6b630267d8b061fb16252ec28b..d4881abe574a4d5d7c7f7a11aa2f7f9f62a2bc0d 100644 (file)
--- a/src/Impostor.Server/Net/Inner/Objects/InnerGameData.cs
+++ b/src/Impostor.Server/Net/Inner/Objects/InnerGameData.cs
@@ -81,7 +81,7 @@ namespace Impostor.Server.Net.Inner.Objects
 
                     while (reader.Position < reader.Length)
                     {
-                        var message = reader.ReadMessage();
+                        using var message = reader.ReadMessage();
                         var player = GetPlayerById(message.Tag);
                         if (player != null)
                         {
@@ -182,4 +182,4 @@ namespace Impostor.Server.Net.Inner.Objects
             }
         }
     }
-}
\ No newline at end of file
+}

diff --git a/src/Impostor.Server/Net/State/Game.Data.cs b/src/Impostor.Server/Net/State/Game.Data.cs
index f42280857cf7421fc199004dfbd5c0bb3b1e46a3..a84d9b59c9dd308cf3ac0e5861e74e8d8070c9ed 100644 (file)
--- a/src/Impostor.Server/Net/State/Game.Data.cs
+++ b/src/Impostor.Server/Net/State/Game.Data.cs
@@ -222,7 +222,7 @@ namespace Impostor.Server.Net.State
             // Parse GameData messages.
             while (parent.Position < parent.Length)
             {
-                var reader = parent.ReadMessage();
+                using var reader = parent.ReadMessage();
 
                 switch (reader.Tag)
                 {
@@ -319,7 +319,7 @@ namespace Impostor.Server.Net.State
                                     break;
                                 }
 
-                                var readerSub = reader.ReadMessage();
+                                using var readerSub = reader.ReadMessage();
                                 if (readerSub.Length > 0)
                                 {
                                     obj.Deserialize(sender, target, readerSub, true);

diff --git a/src/Impostor.Tools.Proxy/Program.cs b/src/Impostor.Tools.Proxy/Program.cs
index b97dd94b274b68a11ecf1e6e88bcc7aac4ed8ad3..468cdd15ec27bc3c7b796e2d1d221836f62b1c85 100644 (file)
--- a/src/Impostor.Tools.Proxy/Program.cs
+++ b/src/Impostor.Tools.Proxy/Program.cs
@@ -111,7 +111,7 @@ namespace Impostor.Tools.Proxy
                         break;
                     }
 
-                    var message = reader.ReadMessage();
+                    using var message = reader.ReadMessage();
                     if (isSent)
                     {
                         HandleToServer(ipSrc, message);