]> git.deb.at Git - rhonda/impostor.git/commitdiff
Fix leaking MessageWriters
authorAeonLucid <aeonlucid@outlook.com>
Thu, 12 Nov 2020 03:34:07 +0000 (04:34 +0100)
committerAeonLucid <aeonlucid@outlook.com>
Thu, 12 Nov 2020 03:34:07 +0000 (04:34 +0100)
src/Impostor.Server/Net/Inner/Objects/Components/InnerCustomNetworkTransform.Api.cs
src/Impostor.Server/Net/Inner/Objects/InnerPlayerControl.Api.cs
src/Impostor.Server/Net/State/Game.cs

index 62236267835e9aeaacd85e6b71ba74dd744b3bcf..6cdd6b91fd81174a501dbedc82791074d6cd056d 100644 (file)
@@ -14,10 +14,12 @@ namespace Impostor.Server.Net.Inner.Objects.Components
             SnapTo(position, minSid);
 
             // Broadcast to all clients.
-            var writer = _game.StartRpc(NetId, RpcCalls.SnapTo);
-            WriteVector2(writer, position);
-            writer.Write(_lastSequenceId);
-            await _game.FinishRpcAsync(writer);
+            using (var writer = _game.StartRpc(NetId, RpcCalls.SnapTo))
+            {
+                WriteVector2(writer, position);
+                writer.Write(_lastSequenceId);
+                await _game.FinishRpcAsync(writer);
+            }
         }
     }
 }
index 95fad02cb599b665c37cfc3b16bc5377e156e436..49076bfc3d9ec9bc997f2ad7cb46aadf886d1ee5 100644 (file)
@@ -99,7 +99,7 @@ namespace Impostor.Server.Net.Inner.Objects
 
         public async ValueTask SetMurderedAsync()
         {
-            var writer = _game.StartRpc(NetId, RpcCalls.MurderPlayer);
+            using var writer = _game.StartRpc(NetId, RpcCalls.MurderPlayer);
             writer.Write((byte)NetId);
             await _game.FinishRpcAsync(writer);
         }
index ed2049dab6638354343057c7cc621a393d643914..19198675e17bdb78e0a6d602ec95cec20b975327 100644 (file)
@@ -16,7 +16,7 @@ using Microsoft.Extensions.Logging;
 
 namespace Impostor.Server.Net.State
 {
-    internal partial class Game : IGame
+    internal partial class Game
     {
         private readonly ILogger<Game> _logger;
         private readonly IServiceProvider _serviceProvider;
@@ -123,4 +123,4 @@ namespace Impostor.Server.Net.State
                 .Select(p => p.Client.Connection);
         }
     }
-}
\ No newline at end of file
+}